[GitHub] michellethomas opened a new pull request #4566: Adding column type label to dropdowns

[GitBox]

michellethomas opened a new pull request #4566: Adding column type label to 
dropdowns
URL: https://github.com/apache/incubator-superset/pull/4566
 
 
   Adding column type information to the optionRenderer for any controls that 
use ColumnOption or MetricOption. So this will show up in the dropdown but not 
inline in the value renderer. This deviates from our original designs but it 
was making the page look pretty busy when I added it to our current page.
   
   Would love to get more design feedback!
   
   In the future, in the metrics section we can distinguish between 
aggregations and columns. Also, once some of the metrics work Gabe is doing 
gets in, I'd like to add this to all dropdowns for consistency. 
   
   @GabeLoins @williaster @mistercrunch 
   
   
![image](https://user-images.githubusercontent.com/817955/37114491-5e9070ba-21fd-11e8-9da8-4a7353cd47dd.png)
   
![image](https://user-images.githubusercontent.com/817955/37114497-671fb02e-21fd-11e8-93f8-865201e93d5a.png)
   
![image](https://user-images.githubusercontent.com/817955/37114507-6fcd641e-21fd-11e8-8abd-84d8c318d2f7.png)
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services