john-bodley closed pull request #4567: [payload] Set status code on error 
rather than query status

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/ b/superset/views/
index 5b0ee5f3bc..038da76b2d 100755
--- a/superset/views/
+++ b/superset/views/
@@ -1084,7 +1084,10 @@ def generate_json(self, datasource_type, datasource_id, 
             return json_error_response(utils.error_msg_from_exception(e))
         status = 200
-        if payload.get('status') == QueryStatus.FAILED:
+        if (
+            payload.get('status') == QueryStatus.FAILED or
+            payload.get('error') is not None
+        ):
             status = 400
         return json_success(viz_obj.json_dumps(payload), status=status)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to