williaster commented on a change in pull request #4566: Adding column type 
label to dropdowns
URL: 
https://github.com/apache/incubator-superset/pull/4566#discussion_r173005251
 
 

 ##########
 File path: superset/assets/javascripts/components/ColumnTypeLabel.jsx
 ##########
 @@ -0,0 +1,34 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+const propTypes = {
+  type: PropTypes.string.isRequired,
+};
+
+export default function ColumnTypeLabel({ type }) {
+  let stringIcon;
+  let iconSize = '13';
 
 Review comment:
   these should all be fine as #s not strings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to