[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view

[GitBox]

tanvach commented on issue #4570: Adding option to visualize negative values in 
Table view
URL: 
https://github.com/apache/incubator-superset/pull/4570#issuecomment-371374038
 
 
   @john-bodley @williaster Thanks for the suggestion. I experimented with this 
idea but turns out the major issue is when all values are negative. The chart 
will then start from the right, which is confusing since it's what we have 
right now.
   
   Comparing these two cases for all positives and negatives.
   
   <img width="826" alt="screen shot 2018-03-07 at 8 52 22 pm" 
src="https://user-images.githubusercontent.com/729913/37133628-7439e0e4-2249-11e8-9081-a1e9ae26261d.png";>
   
   <img width="820" alt="screen shot 2018-03-07 at 8 51 39 pm" 
src="https://user-images.githubusercontent.com/729913/37133607-5f117f10-2249-11e8-9a87-05902c22c22c.png";>
   
   But when the values are mixed it does look pretty nice
   
   <img width="827" alt="screen shot 2018-03-07 at 8 58 22 pm" 
src="https://user-images.githubusercontent.com/729913/37133826-67e8b2b0-224a-11e8-896e-f86a224aacb3.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services