codecov-io commented on issue #4514: Added new exception class and start of 
better exception/error handling
URL: 
https://github.com/apache/incubator-superset/pull/4514#issuecomment-371323920
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=h1)
 Report
   > Merging 
[#4514](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `92.3%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4514/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4514      +/-   ##
   ==========================================
   + Coverage   71.17%   71.18%   +<.01%     
   ==========================================
     Files         187      188       +1     
     Lines       14809    14824      +15     
     Branches     1085     1085              
   ==========================================
   + Hits        10540    10552      +12     
   - Misses       4266     4269       +3     
     Partials        3        3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `78.45% <?> (?)` | :arrow_up: |
   | 
[superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5)
 | `81.81% <100%> (?)` | :arrow_up: |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.39% <100%> (+0.03%)` | :arrow_up: |
   | 
[superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
 | `100% <100%> (?)` | |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.33% <100%> (+0.08%)` | :arrow_up: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `87.83% <100%> (-0.29%)` | :arrow_down: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.13% <60%> (-0.07%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4514/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.18% <0%> (+0.06%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=footer).
 Last update 
[b512da8...d49c6b9](https://codecov.io/gh/apache/incubator-superset/pull/4514?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to