[GitHub] codecov-io commented on issue #4590: Removing escape_sql so we dont double escape

[GitBox]

codecov-io commented on issue #4590: Removing escape_sql so we dont double 
escape
URL: 
https://github.com/apache/incubator-superset/pull/4590#issuecomment-371979771
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=h1)
 Report
   > Merging 
[#4590](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/f9881101ee9cd447f7ccb2d38bc7563f31f686c5?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4590/graphs/tree.svg?width=650&height=150&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4590      +/-   ##
   ==========================================
   + Coverage   71.17%   71.18%   +<.01%     
   ==========================================
     Files         188      188              
     Lines       14834    14828       -6     
     Branches     1086     1086              
   ==========================================
   - Hits        10558    10555       -3     
   + Misses       4273     4270       -3     
     Partials        3        3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=tree)
 | Coverage ? | |
   |---|---|---|
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.26% <?> (+0.01%)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4590/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.91% <?> (+0.11%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=footer).
 Last update 
[f988110...e1af421](https://codecov.io/gh/apache/incubator-superset/pull/4590?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services