john-bodley commented on issue #4590: Removing escape_sql so we dont double escape URL: https://github.com/apache/incubator-superset/pull/4590#issuecomment-372774659 @michellethomas upon further investigation this regression doesn't seem to be related to the auto-escape feature but rather [this](https://github.com/zzzeek/sqlalchemy/commit/2392ae1900f112c44ed966783d1dedfb88f13353) SQLAlchemy commit (released in version `1.2.0`) which escapes percent signs (`%`) for all dialects where the param style is either `format` or `pyformat` per [this](https://github.com/zzzeek/sqlalchemy/blob/e3323df4bd781a593e90c1cb4a187ff37cc04e5a/lib/sqlalchemy/sql/compiler.py#L2999) statement which is [true](https://github.com/dropbox/PyHive/blob/19d7c2b8fb8b19dadeb2339d4d3f42c8f09204c1/pyhive/presto.py#L31) for Presto. Hence by upgrading SQLAlchemy from `1.1.9` to `1.2.2` ([PR](https://github.com/apache/incubator-superset/pull/4299)) the percent signs were doubly escaped in Presto per the `PrestoEngineSpec` causing the regression.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
