[GitHub] williaster opened a new pull request #4607: [slice_json] pass slice id to get_form_data()

[GitBox]

williaster opened a new pull request #4607: [slice_json] pass slice id to 
get_form_data()
URL: https://github.com/apache/incubator-superset/pull/4607
 
 
   @mistercrunch @graceguo-supercat @fabianmenges 
   
   [This 
line](https://github.com/apache/incubator-superset/commit/83524f97d7fcf3c8c86efd25f6e5f76fda1b48f5#diff-ac978615a4f22c4fad4d01f39e1d4595R1091)
 of #4490 broke all non-formula type annotations as it didn't pass the 
`slice_id` through to `get_form_data()`
   
   before:
   
![image](https://user-images.githubusercontent.com/4496521/37363428-27c771d4-26b5-11e8-99bc-8464a3b1b83d.png)
   
   after:
   
![image](https://user-images.githubusercontent.com/4496521/37363370-00526b54-26b5-11e8-9c83-26b355421a1f.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services