john-bodley closed pull request #4579: Removing [dashboard] and [slice] titles 
to show name

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/ b/superset/views/
index d5cd1689c5..0aa34de6a6 100755
--- a/superset/views/
+++ b/superset/views/
@@ -1297,9 +1297,9 @@ def explore(self, datasource_type=None, 
             if datasource_type == 'table' \
             else datasource.datasource_name
         if slc:
-            title = '[slice] ' + slc.slice_name
+            title = slc.slice_name
-            title = '[explore] ' + table_name
+            title = 'Explore - ' + table_name
         return self.render_template(
@@ -2064,7 +2064,7 @@ def dashboard(**kwargs):  # noqa
-            title='[dashboard] ' + dash.dashboard_title,
+            title=dash.dashboard_title,


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to