betodealmeida commented on a change in pull request #4572: Legend for deck.gl 
scatterplot
URL: 
https://github.com/apache/incubator-superset/pull/4572#discussion_r174322258
 
 

 ##########
 File path: superset/assets/visualizations/deckgl/layers/scatter.jsx
 ##########
 @@ -68,8 +89,10 @@ function getLayer(formData, payload, slice, inFrame) {
     data = jsFnMutator(data);
   }
 
-  if (inFrame != null) {
-    data = data.filter(inFrame);
+  if (filters != null) {
+    filters.forEach((f) => {
+      data = data.filter(f);
 
 Review comment:
   Functional JS! ;)
   
   Maybe we should call this `postFilters` or something similar, since it's a 
series of filters applied after the query (due to clicks from the legend or the 
play slider).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to