xrmx commented on a change in pull request #4614: Add sql editor
URL:
https://github.com/apache/incubator-superset/pull/4614#discussion_r174388686
##########
File path: superset/assets/javascripts/explore/stores/controls.jsx
##########
@@ -1197,6 +1197,16 @@ export const controls = {
description: t('What should be shown on the label?'),
},
+ sql: {
+ type: 'TextAreaControl',
+ label: t('Code'),
+ description: t('Put your sql here. This feature is for developers who
understand superset. If you are not sure, please do not fill in anything, it
will be ignored.'),
Review comment:
If this is a joke i don't think it's funny
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
