michellethomas commented on a change in pull request #4627: Move
run_extra_queries outsize of BaseViz init
URL:
https://github.com/apache/incubator-superset/pull/4627#discussion_r175194933
##########
File path: superset/viz.py
##########
@@ -286,6 +285,7 @@ def cache_key(self, query_obj):
def get_payload(self, query_obj=None):
"""Returns a payload of metadata and data"""
+ self.run_extra_queries()
Review comment:
Adding this here means that when loading a slice with extra_queries, those
will always get executed, even if the slice is cached. Is that intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
