mistercrunch closed pull request #4641: Kill Slice naming convention...
URL: https://github.com/apache/incubator-superset/pull/4641
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
b/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
index 00231df4a2..69871dc58f 100644
--- a/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
@@ -49,7 +49,7 @@ class ExploreChartHeader extends React.PureComponent {
this.props.actions.createNewSlice(
data.can_add, data.can_download, data.can_overwrite,
data.slice, data.form_data);
- this.props.addHistory({ isReplace: true, title: `[slice]
${data.slice.slice_name}` });
+ this.props.addHistory({ isReplace: true, title: `[chart]
${data.slice.slice_name}` });
} else {
this.props.actions.updateChartTitle(newTitle);
}
@@ -97,7 +97,7 @@ class ExploreChartHeader extends React.PureComponent {
<TooltipWrapper
label="edit-desc"
- tooltip={t('Edit slice properties')}
+ tooltip={t('Edit chart properties')}
>
<a
className="edit-desc-icon"
diff --git a/superset/assets/javascripts/explore/components/SaveModal.jsx
b/superset/assets/javascripts/explore/components/SaveModal.jsx
index 6cc1a8ca2b..5489fba599 100644
--- a/superset/assets/javascripts/explore/components/SaveModal.jsx
+++ b/superset/assets/javascripts/explore/components/SaveModal.jsx
@@ -129,7 +129,7 @@ class SaveModal extends React.Component {
>
<Modal.Header closeButton>
<Modal.Title>
- {t('Save A Slice')}
+ {t('Save A Chart')}
</Modal.Title>
</Modal.Header>
<Modal.Body>
@@ -150,7 +150,7 @@ class SaveModal extends React.Component {
checked={this.state.action === 'overwrite'}
onChange={this.changeAction.bind(this, 'overwrite')}
>
- {t('Overwrite slice %s', this.props.slice.slice_name)}
+ {t('Overwrite chart %s', this.props.slice.slice_name)}
</Radio>
}
@@ -163,7 +163,7 @@ class SaveModal extends React.Component {
</Radio>
<input
name="new_slice_name"
- placeholder={t('[slice name]')}
+ placeholder={t('[chart name]')}
onChange={this.onChange.bind(this, 'newSliceName')}
onFocus={this.changeAction.bind(this, 'saveas')}
/>
@@ -184,7 +184,7 @@ class SaveModal extends React.Component {
checked={this.state.addToDash === 'existing'}
onChange={this.changeDash.bind(this, 'existing')}
>
- {t('Add slice to existing dashboard')}
+ {t('Add chart to existing dashboard')}
</Radio>
<Select
className="save-modal-selector"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
