michellethomas opened a new issue #4649: Use one library for table components URL: https://github.com/apache/incubator-superset/issues/4649 For table components we are currently using Reactable, our own FilterableTable, and datatables. Reactable hasn't merged any code since Nov 2016. We are seeing an issue with sorting columns in reactable and I submitted an issue in reactable in Oct that no one has responded to. I was going to evaluate different options for other react table components we could use, and thought it might be an opportunity to consolidate on one. I made a list of the different places we are using tables (let me know if there's anything I've missed). Reactable javascripts/SqlLab/components/QueryTable.jsx javascripts/SqlLab/components/VisualizeModal.jsx javascripts/components/AlteredSliceTag.jsx javascripts/explore/components/controls/DatasourceControl.jsx javascripts/profile/components/TableLoader.jsx javascripts/welcome/DashboardTable.jsx visualizations/time_table.jsx visualizations/paired_ttest.js FilterableTable javascripts/SqlLab/components/ResultSet.jsx datatables visualizations/table.js visualizations/pivot_table.js If / when I get a chance to work on this, I'll update this thread with more info. Let me know if anyone has any objections to moving away from reactable and trying to consolidate. cc: @williaster @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
