mistercrunch commented on issue #4555: [examples] let's not use 'date' as a col 
name
URL: 
https://github.com/apache/incubator-superset/pull/4555#issuecomment-374478683
 
 
   I agree about having it as a way to improve the tests and prevent 
regression, though my immediate urge was to fix the examples that were broken 
in MySQL.
   
   In that spirit we do have a unicode-filled dataset in there, we should 
probably add a new dataset with reserved words as columns, table names and 
unicode-ridden column names and such.
   
   Let's fix the examples for now and open an issue to address unicode and 
reserved words support as a task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to