mistercrunch commented on a change in pull request #4655: [druid] Updating
refresh logic
URL:
https://github.com/apache/incubator-superset/pull/4655#discussion_r176275274
##########
File path: superset/connectors/druid/models.py
##########
@@ -220,13 +220,13 @@ def refresh(self, datasource_names, merge_flag,
refreshAll):
if datatype == 'hyperUnique' or datatype == 'thetaSketch':
col_obj.count_distinct = True
# Allow sum/min/max for long or double
- if datatype == 'LONG' or datatype == 'DOUBLE':
+ if datatype == 'LONG' or datatype in ('FLOAT', 'DOUBLE'):
Review comment:
could go `col_obj.is_num()` that comes from the base column class and
includes all these
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
