mistercrunch commented on issue #4663: [Request For Comments][Explore] 
Streamlined metric definitions for SQLA and Druid
URL: 
https://github.com/apache/incubator-superset/pull/4663#issuecomment-375176867
 
 
   This is super neat and innovative. Can we make the `metric` (same as metrics 
but only allows to define one metric) control in-scope for this PR to make sure 
both `metrics` and `metric` are building upon the same building blocks nicely. 
From what I see it should be pretty trivial, maybe by adding a `multiple` 
boolean prop to `MetricsControl` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to