b881659b opened a new issue #4665: Inconsistent inclusion of a footer template
URL: https://github.com/apache/incubator-superset/issues/4665
 
 
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [x] I have reproduced the issue with at least the latest released version 
of superset
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   
   0.23.3
   
   ### Expected results
   
   Adding a file `superset/templates/appbuilder/footer.html` as per the 
appbuilder documentation should include the same fragment on all pages.
   
   ### Actual results
   
   The templates defined in superset do not reference the footer template and 
are thus not included. Others such as those directly from appbuilder still 
support this giving inconsistent results. 
   
   Footer included in, for example, `login/`, `databaseview/list/` but not 
included in `superset/dashboard/...`, `superset/welcome`. 
   
   ### Steps to reproduce
   
   Include a file `superset/templates/appbuilder/footer.html` with any content 
that would be visible when rendered such as `<div>Hello, World</div>` and open 
the views indicated above.
   
   ### Possible solutions
   
   Some method of adding end-of-view content without patching a large set of 
templates would be great. I am thinking of internal/external support links, 
legal notices here. Other mechanisms would be fine too though I am reluctant to 
use JS to add it dynamically to pages, which may or may not work for all users.
   
   As a possible alternative, a documented way of including a notice on the 
login page only (but for all authentication mechanisms) may work but I cannot 
be sure this covers all such use cases (e.g. anonymous access).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to