GabeLoins commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#discussion_r176500159
########## File path: superset/assets/javascripts/explore/components/AggregateOption.jsx ########## @@ -0,0 +1,20 @@ +import React from 'react'; Review comment: I do prefer more files in general.. I think in this instance it makes sense so all the `*Option` components are declared in the same way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
