codecov-io commented on issue #4668: Add NullOption, and use it for Filters
URL: 
https://github.com/apache/incubator-superset/pull/4668#issuecomment-375432207
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=h1)
 Report
   > Merging 
[#4668](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b9965230df9940ca4387f9ac75fab90ed1a9c40a?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `88.88%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4668/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4668      +/-   ##
   ==========================================
   + Coverage   71.37%   71.39%   +0.01%     
   ==========================================
     Files         190      191       +1     
     Lines       14918    14932      +14     
     Branches     1102     1104       +2     
   ==========================================
   + Hits        10648    10660      +12     
   - Misses       4267     4269       +2     
     Partials        3        3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ipts/explore/components/controls/FilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4668/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sLmpzeA==)
 | `97.29% <100%> (ø)` | :arrow_up: |
   | 
[...erset/assets/javascripts/components/NullOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4668/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTnVsbE9wdGlvbi5qc3g=)
 | `100% <100%> (ø)` | |
   | 
[.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4668/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...ipts/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4668/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==)
 | `84.74% <100%> (ø)` | :arrow_up: |
   | 
[...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4668/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4)
 | `77.94% <60%> (-1.43%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=footer).
 Last update 
[b996523...86463d2](https://codecov.io/gh/apache/incubator-superset/pull/4668?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to