jeffreythewang commented on a change in pull request #4451: [cli] Preparing to deprecate wrapping of external commands URL: https://github.com/apache/incubator-superset/pull/4451#discussion_r176561054
########## File path: superset/config.py ########## @@ -42,8 +42,8 @@ VIZ_ROW_LIMIT = 10000 # max rows retrieved by filter select auto complete FILTER_SELECT_ROW_LIMIT = 10000 -SUPERSET_WORKERS = 2 -SUPERSET_CELERY_WORKERS = 32 +SUPERSET_WORKERS = 2 # deprecated +SUPERSET_CELERY_WORKERS = 32 # deprecated SUPERSET_WEBSERVER_ADDRESS = '0.0.0.0' SUPERSET_WEBSERVER_PORT = 8088 Review comment: Sorry for the late response. I primarily meant it as adding a `# deprecated` and `[DEPRECATED]` comment, both in `cli.py` and the sample `config.py`, to the environment variables that are deprecated. I might be wrong, but I only see `SUPERSET_WEBSERVER_PORT`, `SUPERSET_WEBSERVER_ADDRESS`, and `FLASK_USE_RELOAD` used in `cli.py`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
