michellethomas commented on a change in pull request #4556: [WIP] Preview data
URL:
https://github.com/apache/incubator-superset/pull/4556#discussion_r177266387
##########
File path: superset/assets/javascripts/explore/components/PreviewChartPanel.jsx
##########
@@ -0,0 +1,105 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import $ from 'jquery';
+import { List } from 'immutable';
+import { Table } from 'reactable';
+import { withTableAutoSizer } from '@data-ui/data-table';
Review comment:
Chris uses react-virtualized AutoSizer in
[data-table](https://github.com/williaster/data-ui/blob/master/packages/data-table/src/enhancers/withTableAutoSizer.jsx),
so you can use react-virtualized to avoid adding another js package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
