mistercrunch commented on issue #4669: [sqllab] Using app context for 
processing Jinja template in async mode
URL: 
https://github.com/apache/incubator-superset/pull/4669#issuecomment-376567728
 
 
   Agreed, it took me a moment to catch up with your thinking process. Had to 
go through similar reasoning.
   
   For context at the time where the decision was made to process the template 
on the worker, there was no impersonation going on, and it somewhat made sense 
to do more work on the worker. At this point I think it makes sense to render 
the template on the web server. It shouldn't affect query time, only pending 
time may appear a little longer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to