GabeLoins commented on issue #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid URL: https://github.com/apache/incubator-superset/pull/4663#issuecomment-376680826 @mistercrunch @michellethomas thanks for the reviews! I addressed all comments. For Max's more in depth comments: - enabled adhoc metrics on the `metric` controller. Required adding some additional case statements in the MetricsControl component where I assume `value` will be an array. Also required some small style updates. - for making it more clear that the tokens are editable, I had the AdhocMetricEditPopover appear by default when a new metric is created. I also updated the default text in the select component. I also added another feature that HIDES any auto generated metric that is just an aggregate + column.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
