hughhhh commented on a change in pull request #4702: RFC: add logger that logs
into browser console
URL:
https://github.com/apache/incubator-superset/pull/4702#discussion_r177839075
##########
File path: superset/cli.py
##########
@@ -31,11 +32,47 @@ def init():
security.sync_role_definitions()
+def debug_run(app, port, use_reloader):
+ return app.run(
+ host='0.0.0.0',
+ port=int(port),
+ threaded=True,
+ debug=True,
+ use_reloader=use_reloader)
+
+
+def console_log_run(app, port, use_reloader):
+ from console_log import ConsoleLog
Review comment:
Can you put these imports at the top
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
