mistercrunch commented on issue #4704: allow customizable caching permissions
URL: 
https://github.com/apache/incubator-superset/pull/4704#issuecomment-377083886
 
 
   I think this results in double-checking the permission at the moment, which 
is an extra database round trip. I'm not sure how efficient it is either for 
non-all-datasource-access roles, meaning we'd pay a relatively expensive cost 
twice.
   
   Currently the view is in charge of doing data access checks. Since the auth 
scheme here is a FAB (web framework) construct, it could be good to keep those 
check shallow in the stack, meaning in the view layer.
   
   Curious to understand your use case and how the check on cache would differ 
from the datasource check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to