mistercrunch commented on a change in pull request #4689: Move has access to
superset security manager
URL:
https://github.com/apache/incubator-superset/pull/4689#discussion_r177930000
##########
File path: superset/security.py
##########
@@ -92,6 +99,42 @@ def can_access(self, permission_name, view_name, user=None):
return self.is_item_public(permission_name, view_name)
return self._has_view_access(user, permission_name, view_name)
+ def has_method_access(self, f):
Review comment:
It might just be me but I don't like the idea of a decorator as a class
method. It's probably ok though. I guess decorators are already complex in
terms of what's inside them, external context make it more of a stretch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
