[GitHub] codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by post-aggregation metrics

[GitBox]

codecov-io commented on issue #4646: [BugFix] Allowing limit ordering by 
post-aggregation metrics
URL: 
https://github.com/apache/incubator-superset/pull/4646#issuecomment-374430478
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=h1)
 Report
   > Merging 
[#4646](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/069d61c53f03608f05a0684572b9a2bb545fd9a6?src=pr&el=desc)
 will **increase** coverage by `0.12%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4646/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4646      +/-   ##
   ==========================================
   + Coverage   72.22%   72.35%   +0.12%     
   ==========================================
     Files         204      204              
     Lines       15323    15343      +20     
     Branches     1180     1180              
   ==========================================
   + Hits        11067    11101      +34     
   + Misses       4253     4239      -14     
     Partials        3        3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4646/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `81.61% <87.5%> (+2.36%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=footer).
 Last update 
[069d61c...10f4c01](https://codecov.io/gh/apache/incubator-superset/pull/4646?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services