mistercrunch commented on a change in pull request #4724: Improve database type
inference
URL:
https://github.com/apache/incubator-superset/pull/4724#discussion_r178483965
##########
File path: superset/db_engine_specs.py
##########
@@ -550,6 +575,11 @@ def adjust_database_uri(cls, uri, selected_schema=None):
uri.database = database
return uri
+ @classmethod
+ def get_datatype(cls, type_code):
Review comment:
Yes that's the case, I know that Presto should be this method, but I'm
unclear on what the base class should do to capture the most common use cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
