mistercrunch commented on a change in pull request #4688: Added DeckGL Test
URL:
https://github.com/apache/incubator-superset/pull/4688#discussion_r178614964
##########
File path: tests/viz_tests.py
##########
@@ -634,3 +634,109 @@ def test_rose_vis_get_data(self):
],
}
self.assertEqual(expected, res)
+
+
+class BaseDeckGLVizTestCase(unittest.TestCase):
+
+ def test_get_metrics(self):
+ form_data = {'size': 'large'}
Review comment:
Typically a `form_data` dict will be much larger and have as many keys a
specified in that particular viz type. We should talk about a way to test
`viz.py` with examples that represent reality, may by sharing code with the
examples, along with assertions to complete/test the examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
