mistercrunch commented on a change in pull request #4730: Fix deep equality
logic
URL:
https://github.com/apache/incubator-superset/pull/4730#discussion_r178655384
##########
File path: superset/assets/javascripts/reduxUtils.js
##########
@@ -95,5 +96,5 @@ export function areArraysShallowEqual(arr1, arr2) {
}
export function areObjectsEqual(obj1, obj2) {
- return JSON.stringify(obj1) === JSON.stringify(obj2);
+ return equals(obj1, obj2);
Review comment:
Good catch. `==` would have been ok in most cases but `===` is preferable.
We may not need this utility function anymore but I'm leaving it to minimize
code changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
