GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378444952 @mistercrunch yeah I definitely considered that as well when working on it. The big motivator for going with tabs is that the metric definitions could easily hit 4-5 lines if someone was defining a case/if statment. I wanted to give the Ace editor a good amount of space by default so that would be possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
