betodealmeida commented on a change in pull request #4772: [dashboard] open in 
edit mode when adding a chart
URL: 
https://github.com/apache/incubator-superset/pull/4772#discussion_r179858801
 
 

 ##########
 File path: superset/assets/javascripts/explore/components/SaveModal.jsx
 ##########
 @@ -107,7 +107,7 @@ class SaveModal extends React.Component {
       .then((data) => {
         // Go to new slice url or dashboard url
         if (gotodash) {
-          window.location = data.dashboard;
+          window.location = data.dashboard + '&edit=true';
 
 Review comment:
   We might wanna use the `URL` object every where we manipulate URLs to make 
it more robust, eg:
   
   ```javascript
   const url = new URL(data.dashboard);
   url.searchParams.set('edit', 'true');
   window.location = url.href;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to