betodealmeida commented on a change in pull request #4765: [line] fix verbose
names in time shift
URL:
https://github.com/apache/incubator-superset/pull/4765#discussion_r179863177
##########
File path: superset/assets/visualizations/nvd3_vis.js
##########
@@ -83,23 +83,24 @@ function getMaxLabelSize(container, axisClass) {
return Math.max(...labelDimensions);
}
-/* eslint-disable camelcase */
-function formatLabel(column, verbose_map) {
+export function formatLabel(input, verboseMap = {}) {
+ // The input for label may be a string or an array of string
+ // When using the time shift feature, the label contains a '---' in the array
+ const verboseLkp = s => verboseMap[s] || s;
let label;
- if (Array.isArray(column) && column.length) {
- label = verbose_map[column[0]] || column[0];
- if (column.length > 1) {
- label += ', ';
+ if (Array.isArray(input) && input.length) {
+ const verboseLabels = input.filter(s => s !== '---').map(verboseLkp);
+ label = verboseLabels.join(', ');
+ if (input.length > verboseLabels.length) {
+ label += '---';
Review comment:
Did you test leaving a space between the label and the dashes? Seems a bit
cluttered to me without the space there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
