john-bodley commented on issue #4795: [cli] force update perms on superset init
URL: 
https://github.com/apache/incubator-superset/pull/4795#issuecomment-380302796
 
 
   Agreed, I guess what I'm saying is I'm not certain whether we want to always 
ensure that `superset init` overrides the logic of the `SUPERSET_UPDATE_PERMS` 
environment variable or whether one should run it via, 
   ```
   SUPERSET_UPDATE_PERMS=1 superset init
   ```
   as defined 
[here](https://github.com/apache/incubator-superset/blob/master/docs/installation.rst#flask-appbuilder-permissions).
 Note the default return value of `get_update_perms_flag` is `True` is the 
environment variable is undefined.  
   
   I also don't know what the precedence is of whether setting environment 
variables in config files is recommended. Historically it seems we only read 
from them to augment the configuration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to