john-bodley commented on issue #4520: Allow users to view dashboards they own
URL: 
https://github.com/apache/incubator-superset/pull/4520#issuecomment-380530013
 
 
   @jeffreythewang I agree with your logic regarding empty dashboards which 
this PR resolves, but I think your original comment
   > For the case where they are the owner of a dashboard, but their dashboard 
has charts they do not have access to (which can only happen if an additional 
owner adds an inaccessible chart to the dashboard)
   
   is not correct according to the current logic. Maybe it would be good to 
updated the PR title and description to better reflect the change. Also I 
wonder whether a unit test would be valuable here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to