williaster commented on a change in pull request #4791: apply new Dashboard
builder to dashboard
URL:
https://github.com/apache/incubator-superset/pull/4791#discussion_r180888627
##########
File path:
superset/assets/javascripts/dashboard/v2/containers/DashboardGrid.jsx
##########
@@ -7,11 +7,18 @@ import {
resizeComponent,
} from '../actions/dashboardLayout';
+function mapStateToProps({ dashboard }, ownProps) {
+ return {
+ editMode: dashboard.editMode,
+ cells: ownProps.cells,
Review comment:
why are you overwriting cells with the same `ownProps`? also see my comments
about removing cells.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
