williaster commented on a change in pull request #4791: apply new Dashboard
builder to dashboard
URL:
https://github.com/apache/incubator-superset/pull/4791#discussion_r180873274
##########
File path: superset/assets/javascripts/chart/chartReducer.js
##########
@@ -6,6 +6,7 @@ import * as actions from './chartAction';
import { t } from '../locales';
export const chartPropType = {
+ slice_id: PropTypes.number,
chartKey: PropTypes.string.isRequired,
Review comment:
(again this should also be moved to `util/propShapes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
