williaster commented on a change in pull request #4791: apply new Dashboard 
builder to dashboard
URL: 
https://github.com/apache/incubator-superset/pull/4791#discussion_r180887523
 
 

 ##########
 File path: 
superset/assets/javascripts/dashboard/v2/containers/DashboardComponent.jsx
 ##########
 @@ -51,6 +51,11 @@ function mapStateToProps({ dashboardLayout: undoableLayout, 
editMode }, ownProps
         );
       }
     });
+  } else if (props.component.type === CHART_TYPE) {
+    const chartKey = props.component.meta && props.component.meta.chartKey;
 
 Review comment:
   why are you calling this `key` whereas everything else is an `id`? can you 
use `id` instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to