williaster commented on a change in pull request #4791: apply new Dashboard 
builder to dashboard
URL: 
https://github.com/apache/incubator-superset/pull/4791#discussion_r180889672
 
 

 ##########
 File path: superset/assets/javascripts/dashboard/v2/util/propShapes.jsx
 ##########
 @@ -19,6 +19,9 @@ export const componentShape = PropTypes.shape({ // 
eslint-disable-line
     text: PropTypes.string,
     headerSize: PropTypes.oneOf(headerStyleOptions.map(opt => opt.value)),
 
+    // slice id for chart holder
+    chartKey: PropTypes.string,
 
 Review comment:
   please just use the slice id and call it `id`. rule of thumb: most of the 
time you don't need comments if your variables have descriptive names!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to