williaster commented on a change in pull request #4791: apply new Dashboard
builder to dashboard
URL:
https://github.com/apache/incubator-superset/pull/4791#discussion_r180885413
##########
File path:
superset/assets/javascripts/dashboard/v2/components/BuilderComponentPane.jsx
##########
@@ -1,32 +1,67 @@
import React from 'react';
import PropTypes from 'prop-types';
+import cx from 'classnames';
-import NewChart from './gridComponents/new/NewChart';
import NewColumn from './gridComponents/new/NewColumn';
import NewDivider from './gridComponents/new/NewDivider';
import NewHeader from './gridComponents/new/NewHeader';
import NewRow from './gridComponents/new/NewRow';
import NewTabs from './gridComponents/new/NewTabs';
+import SliceAdderContainer from
'../../../dashboard/components/SliceAdderContainer';
const propTypes = {
editMode: PropTypes.bool,
};
class BuilderComponentPane extends React.PureComponent {
+ constructor(props) {
+ super(props);
+ this.state = {
+ showSlices: false,
+ };
+
+ this.toggleSlices = this.toggleSlices.bind(this);
Review comment:
can you call this `toggleSlicePane`? it's not clear what `toggleSlices` means
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
