betodealmeida commented on a change in pull request #4793: [line] do not show 0 
or nulls in rich tooltip
URL: 
https://github.com/apache/incubator-superset/pull/4793#discussion_r180893787
 
 

 ##########
 File path: superset/assets/visualizations/nvd3_vis.js
 ##########
 @@ -424,17 +424,24 @@ export default function nvd3Vis(slice, payload) {
             + '</td></tr></thead><tbody>';
           d.series.sort((a, b) => a.value >= b.value ? -1 : 1);
           d.series.forEach((series) => {
 
 Review comment:
   Might be cleaner/clearer to rewrite this to:
   
   ```javascript
   d.series.filter(series => series.value).forEach((series) => {
   ...
   });
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to