betodealmeida commented on a change in pull request #4800: Improve the calendar heatmap URL: https://github.com/apache/incubator-superset/pull/4800#discussion_r180899647
########## File path: superset/assets/javascripts/explore/stores/controls.jsx ########## @@ -1003,6 +1010,46 @@ export const controls = { 'relative to the time granularity selected'), }, + cell_size: { + type: 'TextControl', + isInt: true, + default: 10, + validators: [v.integer], + renderTrigger: true, + label: t('Cell Size'), + description: t('The size of the square cell, in pixels'), + }, + + cell_padding: { + type: 'TextControl', + isInt: true, + validators: [v.integer], + renderTrigger: true, + default: 2, + label: t('Cell Padding'), + description: t('The distance between cells, in pixels'), + }, + + cell_radius: { + type: 'TextControl', + isInt: true, + validators: [v.integer], + renderTrigger: true, + default: 2, Review comment: Personally, I'd leave this at zero — the round borders look really ugly to me, unless they're full circles. Maybe someone with a better design eye than me can comment on this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services