graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576 thanks for your comment. here is my thoughts: 1. I don't like the idea of delete v1, it will destroy code history and make huge duplicates, huge merge conflicts, and very hard to track the changing or fixing of existed features. Dashboard v2 is a new project, but most of v2's functionalities are same as v1, like filters, chart render, refresh and immune etc. We will add new functions/components to improve the layout and organization of Dashboard, not switch to branch new project. 2. Naming: I don't have good idea about redux state keys. Please feel free to recommend. `charts` are dynamic queries. Each of chart is basically a query based on saved params + dashboard added filter. It's attributes are mostly are dynamic, like request params, response data, start time, last updated time etc. `allSlices` mapped to `slices` table in backend. It has static data for those saved queries (after save query as slice), like name, owner, datasource name, timestamp, param list, etc. These data are used to help user review, filter, sort all existed slices, then they can add new slices into dashboard. Different than chart data that is fetched one by one, available slices data should be fetched all together and only once.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
