[GitHub] mistercrunch commented on a change in pull request #4800: Improve the calendar heatmap

[GitBox]

mistercrunch commented on a change in pull request #4800: Improve the calendar 
heatmap
URL: 
https://github.com/apache/incubator-superset/pull/4800#discussion_r180939868
 
 

 ##########
 File path: superset/assets/javascripts/explore/stores/controls.jsx
 ##########
 @@ -1003,6 +1010,46 @@ export const controls = {
     'relative to the time granularity selected'),
   },
 
+  cell_size: {
+    type: 'TextControl',
+    isInt: true,
+    default: 10,
+    validators: [v.integer],
+    renderTrigger: true,
+    label: t('Cell Size'),
+    description: t('The size of the square cell, in pixels'),
+  },
+
+  cell_padding: {
+    type: 'TextControl',
+    isInt: true,
+    validators: [v.integer],
+    renderTrigger: true,
+    default: 2,
+    label: t('Cell Padding'),
+    description: t('The distance between cells, in pixels'),
+  },
+
+  cell_radius: {
+    type: 'TextControl',
+    isInt: true,
+    validators: [v.integer],
+    renderTrigger: true,
+    default: 2,
 
 Review comment:
   Agreed, I set `cell_radius` to `0` just now. This is `cell_padding` though, 
think I should set this to 0 as well? There's this annoying ghost black spots 
that happens in the corners 👻 
   <img width="671" alt="screen shot 2018-04-11 at 3 11 28 pm" 
src="https://user-images.githubusercontent.com/487433/38650726-4d9fd4c8-3db2-11e8-997e-7a24a81740ba.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services