codecov-io commented on issue #4651: [explore] proper filtering of NULLs and ''
URL: 
https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=h1)
 Report
   > Merging 
[#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/6fd4ff45ea7836195f8209ea43e5666b19d1b3d0?src=pr&el=desc)
 will **increase** coverage by `0.11%`.
   > The diff coverage is `79.48%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4651/graphs/tree.svg?src=pr&width=650&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4651      +/-   ##
   ==========================================
   + Coverage   72.31%   72.43%   +0.11%     
   ==========================================
     Files         208      208              
     Lines       15547    15598      +51     
     Branches     1204     1212       +8     
   ==========================================
   + Hits        11243    11298      +55     
   + Misses       4301     4297       -4     
     Partials        3        3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbW1vbi5qcw==)
 | `40% <100%> (+40%)` | :arrow_up: |
   | 
[superset/assets/javascripts/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL2NvbW1vbi5qcw==)
 | `60.52% <100%> (+12.25%)` | :arrow_up: |
   | 
[.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz)
 | `52.52% <33.33%> (-0.6%)` | :arrow_down: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `76.5% <50%> (-0.93%)` | :arrow_down: |
   | 
[superset/assets/javascripts/SqlLab/actions.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9hY3Rpb25zLmpz)
 | `72.44% <50%> (+0.12%)` | :arrow_up: |
   | 
[...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4)
 | `78.46% <66.66%> (-0.91%)` | :arrow_down: |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `81.16% <75%> (-0.45%)` | :arrow_down: |
   | 
[superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==)
 | `90.5% <86.95%> (-0.61%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.33% <0%> (+0.83%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=footer).
 Last update 
[6fd4ff4...2b9336e](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to