[GitHub] williaster commented on issue #4843: [formats] add better defaults for time + number formatting

[GitBox]

williaster commented on issue #4843: [formats] add better defaults for time + 
number formatting
URL: 
https://github.com/apache/incubator-superset/pull/4843#issuecomment-382897823
 
 
   Tested this with a  bunch of production examples and fixed a bug where 
`undefined` for showing min/max resulted in `truthy` interpretation by nvd3. 
Here's an example, note verbose format in tooltips + reduced y-axis tick count.
   
   <img 
src="https://user-images.githubusercontent.com/4496521/39020908-65242b12-43e3-11e8-9c03-c77c1540b6cc.png";
 width="600" />
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services