mistercrunch closed pull request #3411: bugfix: checkbox control getting
invalid prop type
URL: https://github.com/apache/incubator-superset/pull/3411
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/components/Checkbox.jsx
b/superset/assets/javascripts/components/Checkbox.jsx
index b0564ae6b8..ec87553587 100644
--- a/superset/assets/javascripts/components/Checkbox.jsx
+++ b/superset/assets/javascripts/components/Checkbox.jsx
@@ -12,7 +12,7 @@ export default function Checkbox({ checked, onChange, style
}) {
<span style={style}>
<i
className={`fa fa-check ${checked ? 'text-primary' :
'text-transparent'}`}
- onClick={onChange.bind(!checked)}
+ onClick={onChange.bind(null, !checked)}
style={{
border: '1px solid #aaa',
borderRadius: '2px',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
