stillmatic opened a new pull request #4869: remove DISTINCT ON statement URL: https://github.com/apache/incubator-superset/pull/4869 this function is used in the 'Enable Filter Select' function. Because it passes `column_name` to `distinct` the function is only usable by backends which support the `DISTINCT ON` statement, i.e. only postgres. Here is (gist of) the error string I get: ``` SELECT DISTINCT ON is not supported [SQL: 'SELECT DISTINCT ON (column_name) column_name AS column_name \nFROM public.table_name \n LIMIT 10000 (Background on this error at: http://sqlalche.me/e/tw8g) ``` DISTINCT ON is only meaningful when selecting values from multiple columns. Because we are selecting rows from only one column, the above processed statement is logically identical to `SELECT DISTINCT column_name FROM table_name LIMIT 10`. this passes CI / tox / etc since it's a one line change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
