mistercrunch commented on a change in pull request #4833: [sqllab] Help sqllab
forget query history
URL:
https://github.com/apache/incubator-superset/pull/4833#discussion_r183600591
##########
File path: superset/views/core.py
##########
@@ -2532,6 +2532,20 @@ def queries(self, last_updated_ms):
# UTC date time, same that is stored in the DB.
last_updated_dt = utils.EPOCH + timedelta(seconds=last_updated_ms_int
/ 1000)
+ # Before you run the select query, also update the query.
+
+ now = int(round(time.time() * 1000))
+
+ update(Query).where(Query.user_id == g.user.get_id()).\
Review comment:
Nope, we can't run an update every time we poll, this runs hundreds of times
per second at Airbnb. This won't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
